netdev - Re: [PATCH] samples: bpf: fix outdated README build command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 10:24:50 +0100
From:   Toke Høiland-Jørgensen <thoiland@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        "Daniel T. Lee" <danieltimlee@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Björn Töpel <bjorn.topel@...el.com>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] samples: bpf: fix outdated README build command

Andrii Nakryiko <andrii.nakryiko@...il.com> writes:

> On Sun, Nov 10, 2019 at 12:19 AM Daniel T. Lee <danieltimlee@...il.com> wrote:
>>
>> Currently, building the bpf samples under samples/bpf directory isn't
>> working. Running make from the directory 'samples/bpf' will just shows
>> following result without compiling any samples.
>>
>
> Do you mind trying to see if it's possible to detect that plain `make`
> is being run from samples/bpf subdirectory, and if that's the case,
> just running something like `make M=samples/bpf -C ../../`? If that's
> not too hard, it would be a nice touch to still have it working old
> (and intuitive) way, IMO.

I think it's just the M= that's missing. Tentatively, the below seems to
work for me (I get some other compile errors, but I think that is
unrelated).

-Toke


diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 8a9af3ab7769..48e7f1ff7861 100644
--- a/samples/bpf/Makefile
+++ b/samples/bpf/Makefile
@@ -246,7 +246,7 @@ endif
 
 # Trick to allow make to be run from this directory
 all:
-       $(MAKE) -C ../../ $(CURDIR)/ BPF_SAMPLES_PATH=$(CURDIR)
+       $(MAKE) -C ../../ M=$(CURDIR) BPF_SAMPLES_PATH=$(CURDIR)
 
 clean:
        $(MAKE) -C ../../ M=$(CURDIR) clean