netdev - Re: [PATCH net-next] lwtunnel: ignore any TUNNEL_OPTIONS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 13:40:43 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net,
        David Ahern <dsahern@...il.com>, Thomas Graf <tgraf@...g.ch>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH net-next] lwtunnel: ignore any TUNNEL_OPTIONS_PRESENT
 flags set by users

On Sun, Nov 10, 2019 at 12:26:21PM +0800, Xin Long wrote:
> TUNNEL_OPTIONS_PRESENT (TUNNEL_GENEVE_OPT|TUNNEL_VXLAN_OPT|
> TUNNEL_ERSPAN_OPT) flags should be set only according to
> tb[LWTUNNEL_IP_OPTS], which is done in ip_tun_parse_opts().
> 
> When setting info key.tun_flags, the TUNNEL_OPTIONS_PRESENT
> bits in tb[LWTUNNEL_IP(6)_FLAGS] passed from users should
> be ignored.
> 
> While at it, replace all (TUNNEL_GENEVE_OPT|TUNNEL_VXLAN_OPT|
> TUNNEL_ERSPAN_OPT) with 'TUNNEL_OPTIONS_PRESENT'.
> 
> Fixes: 3093fbe7ff4b ("route: Per route IP tunnel metadata via lightweight tunnel")
> Fixes: 32a2b002ce61 ("ipv6: route: per route IP tunnel metadata via lightweight tunnel")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>