netdev - Re: [PATCH] samples: bpf: fix outdated README build command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEKGpzgaMSFy9p8-j5UXsP6RCEYmqDq5CA0NEC1oSNr1ws=-7A@mail.gmail.com>
Date:   Tue, 12 Nov 2019 20:48:15 +0900
From:   "Daniel T. Lee" <danieltimlee@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Björn Töpel <bjorn.topel@...el.com>,
        Andrii Nakryiko <andriin@...com>,
        netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] samples: bpf: fix outdated README build command

On Mon, Nov 11, 2019 at 10:58 PM Daniel Borkmann <daniel@...earbox.net> wrote:
>
> On 11/10/19 9:19 AM, Daniel T. Lee wrote:
> > Currently, building the bpf samples under samples/bpf directory isn't
> > working. Running make from the directory 'samples/bpf' will just shows
> > following result without compiling any samples.
> >
> >   $ make
> >   make -C ../../ /git/linux/samples/bpf/ BPF_SAMPLES_PATH=/git/linux/samples/bpf
> >   make[1]: Entering directory '/git/linux'
> >     CALL    scripts/checksyscalls.sh
> >     CALL    scripts/atomic/check-atomics.sh
> >     DESCEND  objtool
> >   make[1]: Leaving directory '/git/linux'
> >
> > Due to commit 394053f4a4b3 ("kbuild: make single targets work more
> > correctly"), building samples/bpf without support of samples/Makefile
> > is unavailable. Instead, building the samples with 'make M=samples/bpf'
> > from the root source directory will solve this issue.[1]
> >
> > This commit fixes the outdated README build command with samples/bpf.
> >
> > [0]: https://patchwork.kernel.org/patch/11168393/
> >
> > Signed-off-by: Daniel T. Lee <danieltimlee@...il.com>
>
> Thanks for the patch, Daniel! Looks like it's not rebased to the latest bpf-next
> tree and therefore doesn't apply cleanly.
>
> Meanwhile, https://patchwork.ozlabs.org/patch/1192639/ was sent which addresses
> the same issue.
>
> Best,
> Daniel

Thanks for the review.
Seems the issue has been already solved!