netdev - Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to a separate folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hqYynoGwfd=g3rZFgYSKNxsv8PXstD+6btopykweEi1dw@mail.gmail.com>
Date:   Tue, 12 Nov 2019 15:40:35 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        netdev <netdev@...r.kernel.org>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 10/12] net: dsa: vitesse: move vsc73xx driver to
 a separate folder

On Tue, 12 Nov 2019 at 15:09, Alexandre Belloni
<alexandre.belloni@...tlin.com> wrote:
>
> Hi,
>
> On 12/11/2019 14:44:18+0200, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@....com>
> >
> > The vitesse/ folder will contain drivers for switching chips derived
> > from legacy Vitesse IPs (VSC family), including those produced by
> > Microsemi and Microchip (acquirers of Vitesse).
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> > ---
> >  drivers/net/dsa/Kconfig                       | 31 +------------------
> >  drivers/net/dsa/Makefile                      |  4 +--
> >  drivers/net/dsa/vitesse/Kconfig               | 31 +++++++++++++++++++
> >  drivers/net/dsa/vitesse/Makefile              |  3 ++
> >  .../vsc73xx-core.c}                           |  2 +-
> >  .../vsc73xx-platform.c}                       |  2 +-
> >  .../vsc73xx-spi.c}                            |  2 +-
> >  .../{vitesse-vsc73xx.h => vitesse/vsc73xx.h}  |  0
> >  8 files changed, 39 insertions(+), 36 deletions(-)
> >  create mode 100644 drivers/net/dsa/vitesse/Kconfig
> >  create mode 100644 drivers/net/dsa/vitesse/Makefile
> >  rename drivers/net/dsa/{vitesse-vsc73xx-core.c => vitesse/vsc73xx-core.c} (99%)
> >  rename drivers/net/dsa/{vitesse-vsc73xx-platform.c => vitesse/vsc73xx-platform.c} (99%)
> >  rename drivers/net/dsa/{vitesse-vsc73xx-spi.c => vitesse/vsc73xx-spi.c} (99%)
> >  rename drivers/net/dsa/{vitesse-vsc73xx.h => vitesse/vsc73xx.h} (100%)
> >
>
> As there are no commonalities between the vsc73xx and felix drivers,
> shouldn't you simply leave that one out and have felix in the existing
> microchip folder?
>

I don't have a strong preference, although where I come from, all new
NXP networking drivers are still labeled as "freescale" even though
there is no code reuse. There are even less commonalities with
Microchip (ex-Micrel, if I am not mistaken) KSZ switches than with the
old vsc73xx. I'll let the ex-Vitesse people decide.


> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com