netdev - Re: [PATCH net-next 07/12] net: mscc: ocelot: separate the implementation of switch reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hpH7O_O83KD-oEJ4c7iu2VsXJFQm2upNadD7xxOv7dvfw@mail.gmail.com>
Date:   Tue, 12 Nov 2019 15:59:37 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        netdev <netdev@...r.kernel.org>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 07/12] net: mscc: ocelot: separate the
 implementation of switch reset

On Tue, 12 Nov 2019 at 15:56, Andrew Lunn <andrew@...n.ch> wrote:
>
> On Tue, Nov 12, 2019 at 02:44:15PM +0200, Vladimir Oltean wrote:
> > From: Vladimir Oltean <vladimir.oltean@....com>
> >
> > The Felix switch has a different reset procedure, so a function pointer
> > needs to be created and added to the ocelot_ops structure.
> >
> > The reset procedure has been moved into ocelot_init.
> >
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> > ---
> >  drivers/net/ethernet/mscc/ocelot.c       |  3 ++
> >  drivers/net/ethernet/mscc/ocelot.h       |  1 +
> >  drivers/net/ethernet/mscc/ocelot_board.c | 37 +++++++++++++++---------
>
> I'm wondering about the name board. So far, the code you have moved
> into ocelot_board has nothing to do with the board as such. This is
> not a GPIO used to reset the switch, it is not a regulator, etc. It is
> all internal to the device, but just differs per family. Maybe you can
> think of a better name?
>

Alexandre, what do you think? I agree "ocelot_board" is a bit strange.

> Reviewed-by: Andrew Lunn <andrew@...n.ch>
>
>     Andrew