netdev - Re: [PATCH net-next 08/12] net: mscc: ocelot: publish structure definitions to include/soc/mscc/ocelot.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Nov 2019 18:18:27 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Joergen Andreasen <joergen.andreasen@...rochip.com>,
        "Allan W. Nielsen" <allan.nielsen@...rochip.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        netdev <netdev@...r.kernel.org>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 08/12] net: mscc: ocelot: publish structure
 definitions to include/soc/mscc/ocelot.h

On Tue, 12 Nov 2019 at 16:42, Andrew Lunn <andrew@...n.ch> wrote:
>
> > diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h
>
> ..
>
> > +#else
> > +
> > +/* I/O */
> > +u32 ocelot_port_readl(struct ocelot_port *port, u32 reg)
> > +{
> > +     return 0;
> > +}
>
> These stubs are for when the core is missing? I don't think that makes
> sense. What use is a DSA or switchdev driver without the core? I would
> put in a hard dependency in the Kconfig, so the DSA driver can only be
> built when the core is available, and skip these stubs.
>
>       Andrew

Yes it doesn't make too much sense, I was on the fence about adding it
and then just decided to play on the safe side. I'll remove it.