netdev - Re: [PATCH net-next] net/sched: actions: remove unused 'order'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191112190450.6b5786fb@ceranb>
Date:   Tue, 12 Nov 2019 19:04:50 +0100
From:   Ivan Vecera <ivecera@...hat.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Vlad Buslov <vladbu@...lanox.com>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next] net/sched: actions: remove unused 'order'

On Tue, 12 Nov 2019 15:33:11 +0100
Davide Caratti <dcaratti@...hat.com> wrote:

> after commit 4097e9d250fb ("net: sched: don't use tc_action->order during
> action dump"), 'act->order' is initialized but then it's no more read, so
> we can just remove this member of struct tc_action.
> 
> CC: Ivan Vecera <ivecera@...hat.com>
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>
> ---
>  include/net/act_api.h | 1 -
>  net/sched/act_api.c   | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/include/net/act_api.h b/include/net/act_api.h
> index 0495bdc034d2..71347a90a9d1 100644
> --- a/include/net/act_api.h
> +++ b/include/net/act_api.h
> @@ -23,7 +23,6 @@ struct tc_action_ops;
>  struct tc_action {
>  	const struct tc_action_ops	*ops;
>  	__u32				type; /* for backward compat(TCA_OLD_COMPAT) */
> -	__u32				order;
>  	struct tcf_idrinfo		*idrinfo;
>  
>  	u32				tcfa_index;
> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
> index bda1ba25c59e..7fc1e2c1b656 100644
> --- a/net/sched/act_api.c
> +++ b/net/sched/act_api.c
> @@ -1003,7 +1003,6 @@ int tcf_action_init(struct net *net, struct tcf_proto *tp, struct nlattr *nla,
>  			err = PTR_ERR(act);
>  			goto err;
>  		}
> -		act->order = i;
>  		sz += tcf_action_fill_size(act);
>  		/* Start from index 0 */
>  		actions[i - 1] = act;

Reviewed-by: Ivan Vecera <ivecera@...hat.com>