netdev - Re: [PATCH net-next v2] net: openvswitch: add hash info to upcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191111.161201.88134333908165523.davem@davemloft.net>
Date:   Mon, 11 Nov 2019 16:12:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     pshelar@....org, blp@....org, netdev@...r.kernel.org,
        dev@...nvswitch.org, ychen103103@....com
Subject: Re: [PATCH net-next v2] net: openvswitch: add hash info to upcall

From: xiangxia.m.yue@...il.com
Date: Sun, 10 Nov 2019 19:54:04 +0800

> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> When using the kernel datapath, the upcall don't
> add skb hash info relatived. That will introduce
> some problem, because the hash of skb is very
> important (e.g. vxlan module uses it for udp src port,
> tx queue selection on tx path.).
> 
> For example, there will be one upcall, without information
> skb hash, to ovs-vswitchd, for the first packet of one tcp
> session. When kernel sents the tcp packets, the hash is
> random for a tcp socket:
 ...
> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-October/364062.html
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> ---
> v2: add define before #endif

OVS folks, please review.

Thanks.