netdev - Re: [PATCH net-next 2/2] bridge: implement get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191111.144143.1922066976980512193.davem@davemloft.net>
Date:   Mon, 11 Nov 2019 14:41:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     mschiffer@...verse-factory.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com
Subject: Re: [PATCH net-next 2/2] bridge: implement get_link_ksettings
 ethtool method

From: Matthias Schiffer <mschiffer@...verse-factory.net>
Date: Sat,  9 Nov 2019 18:54:14 +0100

> +		if (cmd->base.speed == (__u32)SPEED_UNKNOWN ||
> +		    cmd->base.speed < ecmd.base.speed) {
> +			cmd->base.speed = ecmd.base.speed;
> +		}

Curly braces are unnecessary for single line statements, so please remove.