netdev - Re: [PATCH net] net/smc: fix refcount non-blocking connect() -part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191112.121749.1249383492212187557.davem@davemloft.net>
Date:   Tue, 12 Nov 2019 12:17:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kgraul@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        heiko.carstens@...ibm.com, raspl@...ux.ibm.com,
        ubraun@...ux.ibm.com
Subject: Re: [PATCH net] net/smc: fix refcount non-blocking connect() -part
 2

From: Karsten Graul <kgraul@...ux.ibm.com>
Date: Tue, 12 Nov 2019 16:03:41 +0100

> From: Ursula Braun <ubraun@...ux.ibm.com>
> 
> If an SMC socket is immediately terminated after a non-blocking connect()
> has been called, a memory leak is possible.
> Due to the sock_hold move in
> commit 301428ea3708 ("net/smc: fix refcounting for non-blocking connect()")
> an extra sock_put() is needed in smc_connect_work(), if the internal
> TCP socket is aborted and cancels the sk_stream_wait_connect() of the
> connect worker.
> 
> Reported-by: syzbot+4b73ad6fc767e576e275@...kaller.appspotmail.com
> Fixes: 301428ea3708 ("net/smc: fix refcounting for non-blocking connect()")
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@...ux.ibm.com>

Applied.

And since 301428ea3708 went to -stable, I'll queue this up too.

Thanks.