netdev - RE: [PATCH v1 net-next] mscc.c: Add support for additional VSC PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Nov 2019 20:43:54 +0000
From:   <Bryan.Whitehead@...rochip.com>
To:     <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v1 net-next] mscc.c: Add support for additional VSC PHYs

> From: Bryan Whitehead <Bryan.Whitehead@...rochip.com>
> Date: Tue, 12 Nov 2019 10:54:08 -0500
> 
> >  		phy = container_of(map[addr], struct phy_device, mdio);
> 
> Unnecessary space added between this assignment and the test.
> 
> > +		if (!phy)
> > +			continue;
> 
> And this test makes no sense, the result of container_of() is never NULL
> unless it is for the first member of a structure of a NULL pointer.

Hi David,

I do have a NULL case, so I can check map[addr] for NULL instead.

Thanks,
Bryan