netdev - Re: [PATCH net-next 12/12] net: dsa: vitesse: add tagger for Ocelot/Felix switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d7ede34-dd8e-fbdd-c15a-bb1d8861470a@gmail.com>
Date:   Tue, 12 Nov 2019 13:48:48 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, jakub.kicinski@...ronome.com,
        davem@...emloft.net, alexandre.belloni@...tlin.com
Cc:     andrew@...n.ch, vivien.didelot@...il.com,
        joergen.andreasen@...rochip.com, allan.nielsen@...rochip.com,
        horatiu.vultur@...rochip.com, claudiu.manoil@....com,
        netdev@...r.kernel.org, Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 12/12] net: dsa: vitesse: add tagger for
 Ocelot/Felix switches

On 11/12/19 4:44 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> While it is entirely possible that this tagger format is in fact more
> generic than just these 2 switch families, I don't have that knowledge.
> The Seville switch in NXP T1040 has a similar frame format, but there
> are enough differences (e.g. DEST field starts at bit 57 instead of 56)
> that calling this file tag_vitesse.c is a bit of a stretch at the
> moment. The frame format has been listed in a comment so that people who
> add support for further Vitesse switches can rework this tagger while
> keeping compatibility with Felix.
> 
> The "ocelot" name was chosen instead of "felix" because even the Ocelot
> switch can act as a DSA device when it is used in NPI mode, and the Felix
> tagger format is almost identical. Currently it is only used for the
> Felix switch embedded in the NXP LS1028A chip.
> 
> The ABI for this tagger should be considered "not stable" at the moment.
> The DSA tag is always placed before the Ethernet header and therefore,
> we are using the long prefix for RX tags to avoid putting the DSA master
> port in promiscuous mode. Once there will be an API in DSA for drivers
> to request DSA masters to be in promiscuous mode unconditionally, we
> will switch to the "no prefix" extraction frame header, which will save
> 16 padding bytes for each RX frame.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian