netdev - Re: [PATCH net] dpaa2-eth: free already allocated channels on probe defer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191111.220151.1774638899132375551.davem@redhat.com>
Date:   Mon, 11 Nov 2019 22:01:51 -0800 (PST)
From:   David Miller <davem@...hat.com>
To:     ioana.ciornei@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] dpaa2-eth: free already allocated channels on
 probe defer

From: Ioana Ciornei <ioana.ciornei@....com>
Date: Mon, 11 Nov 2019 11:40:55 +0200

> The setup_dpio() function tries to allocate a number of channels equal
> to the number of CPUs online. When there are no enough DPCON objects
> already probed, the function will return EPROBE_DEFER. When this
> happens, the already allocated channels are not freed. This results in
> the incapacity of properly probing the next time around.
> Fix this by freeing the channels on the error path.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Please add an appropriate Fixes: tag and resubmit.