netdev - Re: [PATCH] net: add missing semicolon in net_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191112070123.GA67139@TonyMac-Alibaba>
Date:   Tue, 12 Nov 2019 15:01:23 +0800
From:   Tony Lu <tonylu@...ux.alibaba.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     mingo@...hat.com, sanagi.koki@...fujitsu.co, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] net: add missing semicolon in net_dev_template

On Mon, Nov 11, 2019 at 06:12:28PM -0500, Steven Rostedt wrote:
> On Mon, 11 Nov 2019 22:17:53 +0800
> Tony Lu <tonylu@...ux.alibaba.com> wrote:
> 
> > This patch adds missing semicolon in the end of net_dev_template.
> > 
> > Fixes: cf66ba58b5cb ("netdev: Add tracepoints to netdev layer")
> > Signed-off-by: Tony Lu <tonylu@...ux.alibaba.com>
> > ---
> >  include/trace/events/net.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/trace/events/net.h b/include/trace/events/net.h
> > index 2399073c3afc..3b28843652d2 100644
> > --- a/include/trace/events/net.h
> > +++ b/include/trace/events/net.h
> > @@ -138,7 +138,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
> >  
> >  	TP_printk("dev=%s skbaddr=%p len=%u",
> >  		__get_str(name), __entry->skbaddr, __entry->len)
> > -)
> > +);
> 
> Actually, we are thinking of making a sweeping patch set to remove all
> these semicolons, as they are not needed, and would also allow more
> flexible processing of the trace event macros.
> 
> -- Steve

Thanks for your reply, it's great to take actions to sweep them for a
unified code style. I just found a different place in the code :-)

Cheers
Tony Lu

> 
> >  
> >  DEFINE_EVENT(net_dev_template, net_dev_queue,
> >