netdev - Re: [PATCH net-next v2] net: dsa: Prevent usage of NET_DSA_TAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191112.194654.825424933050239161.davem@davemloft.net>
Date:   Tue, 12 Nov 2019 19:46:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, olteanv@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dsa: Prevent usage of
 NET_DSA_TAG_8021Q as tagging protocol

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 11 Nov 2019 20:38:46 -0800

> It is possible for a switch driver to use NET_DSA_TAG_8021Q as a valid
> DSA tagging protocol since it registers itself as such, unfortunately
> since there are not xmit or rcv functions provided, the lack of a xmit()
> function will lead to a NPD in dsa_slave_xmit() to start with.
> 
> net/dsa/tag_8021q.c is only comprised of a set of helper functions at
> the moment, but is not a fully autonomous or functional tagging "driver"
> (though it could become later on). We do not have any users of
> NET_DSA_TAG_8021Q so now is a good time to make sure there are not
> issues being encountered by making this file strictly a place holder for
> helper functions.
> 
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks.