[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <VE1PR04MB649695013989E34998A285ED92760@VE1PR04MB6496.eurprd04.prod.outlook.com>
Date: Wed, 13 Nov 2019 04:55:12 +0000
From: Po Liu <po.liu@....com>
To: David Miller <davem@...emloft.net>,
"simon.horman@...ronome.com" <simon.horman@...ronome.com>
CC: Claudiu Manoil <claudiu.manoil@....com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"vinicius.gomes@...el.com" <vinicius.gomes@...el.com>,
Vladimir Oltean <vladimir.oltean@....com>,
Alexandru Marginean <alexandru.marginean@....com>,
Xiaoliang Yang <xiaoliang.yang_1@....com>,
Roy Zang <roy.zang@....com>, Mingkai Hu <mingkai.hu@....com>,
Jerry Huang <jerry.huang@....com>, Leo Li <leoyang.li@....com>
Subject: RE: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware
Scheduler via tc-taprio offload
Hi David,
Thanks!
Br,
Po Liu
> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: 2019年11月13日 3:00
> To: simon.horman@...ronome.com
> Cc: Po Liu <po.liu@....com>; Claudiu Manoil <claudiu.manoil@....com>;
> linux-kernel@...r.kernel.org; netdev@...r.kernel.org;
> vinicius.gomes@...el.com; Vladimir Oltean <vladimir.oltean@....com>;
> Alexandru Marginean <alexandru.marginean@....com>; Xiaoliang Yang
> <xiaoliang.yang_1@....com>; Roy Zang <roy.zang@....com>; Mingkai Hu
> <mingkai.hu@....com>; Jerry Huang <jerry.huang@....com>; Leo Li
> <leoyang.li@....com>
> Subject: [EXT] Re: [net-next, 1/2] enetc: Configure the Time-Aware Scheduler via
> tc-taprio offload
>
> Caution: EXT Email
>
> From: David Miller <davem@...emloft.net>
> Date: Tue, 12 Nov 2019 10:58:59 -0800 (PST)
>
> >
> > Oops, I didn't see this feedback because v2 had been posted.
> >
> > I'll revert that now.
> >
> > Please address Simon's feedback on these two patches, and then post a
> > v3, thank you.
>
> Also, v2 doesn't even compile :-(
>
> In file included from drivers/net/ethernet/freescale/enetc/enetc.h:14,
> from drivers/net/ethernet/freescale/enetc/enetc_qos.c:4:
> drivers/net/ethernet/freescale/enetc/enetc_qos.c: In function
> ʽenetc_setup_tc_taprioʼ:
> drivers/net/ethernet/freescale/enetc/enetc_hw.h:308:32: warning: ʽtempʼ may
> be used uninitialized in this function [-Wmaybe-uninitialized] #define
> enetc_wr_reg(reg, val) iowrite32((val), (reg))
> ^~~~~~~~~
> drivers/net/ethernet/freescale/enetc/enetc_qos.c:59:6: note: ʽtempʼ was
> declared here
More delete one line. Will fix in v3.
> u32 temp;
> ^~~~
> ERROR: "enetc_sched_speed_set" [drivers/net/ethernet/freescale/enetc/fsl-
> enetc-vf.ko] undefined!
> ERROR: "enetc_setup_tc_taprio" [drivers/net/ethernet/freescale/enetc/fsl-
> enetc-vf.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1282: modules] Error 2
I got this situation.
It happened when set module mode, since vf drvier should not own the taprio set.
Thanks!
Powered by blists - more mailing lists