netdev - Re: [PATCH 06/18] octeontx2-af: Add per CGX port level NIX Rx/Tx counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+sq2Ces4OdUcgEkxMXdmMyrOrDjETmA+U+nvmQtLUpoTj2-nw@mail.gmail.com>
Date:   Wed, 13 Nov 2019 12:11:46 +0530
From:   Sunil Kovvuri <sunil.kovvuri@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Linux Netdev List <netdev@...r.kernel.org>,
        Linu Cherian <lcherian@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 06/18] octeontx2-af: Add per CGX port level NIX Rx/Tx counters

On Wed, Nov 13, 2019 at 8:57 AM David Miller <davem@...emloft.net> wrote:
>
> From: sunil.kovvuri@...il.com
> Date: Tue, 12 Nov 2019 00:08:02 +0530
>
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > index 7d7133c..10cd5da 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
>  ...
> > +static inline int cgxlmac_to_pf(struct rvu *rvu, int cgx_id, int lmac_id)
>
> I know it's already happening in this file, but do not use the inline keyword
> in foo.c files please let the compiler decide.

Okay, will fix this in all patches and resubmit.

Thanks,
Sunil.