netdev - Re: [PATCH net-next v2] net: macb: convert to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191113081647.GC4783@kwain>
Date:   Wed, 13 Nov 2019 09:16:47 +0100
From:   Antoine Tenart <antoine.tenart@...tlin.com>
To:     David Miller <davem@...emloft.net>
Cc:     antoine.tenart@...tlin.com, linux@...linux.org.uk, andrew@...n.ch,
        alexandre.belloni@...tlin.com, nicolas.ferre@...rochip.com,
        netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        mparab@...ence.com, piotrs@...ence.com, dkangude@...ence.com,
        ewanm@...ence.com, arthurm@...ence.com, stevenh@...ence.com
Subject: Re: [PATCH net-next v2] net: macb: convert to phylink

Hi David,

On Tue, Nov 12, 2019 at 11:43:57AM -0800, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@...tlin.com>
> Date: Tue, 12 Nov 2019 15:25:48 +0100
> 
> > This patch converts the MACB Ethernet driver to the Phylink framework.
> > The MAC configuration is moved to the Phylink ops and Phylink helpers
> > are now used in the ethtools functions. This helps to access the flow
> > control and pauseparam logic and this will be helpful in the future
> > for boards using this controller with SFP cages.
> > 
> > Tested-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>
> 
> Things like pulling out the buffer init code into a helper function are
> separate from the actual phylink conversion, so please split these changes
> out into separate patches and make this a bonafide patch series.
> 
> Please do not forget to provide an appropriate patch series header
> posting when you do this.

Will do for v3.

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com