netdev - Re: [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87woc4qdea.fsf@miraculix.mork.no>
Date:   Wed, 13 Nov 2019 11:27:57 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Aleksander Morgado <aleksander@...ksander.es>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] net: usb: qmi_wwan: add support for Foxconn T77W968 LTE modules

Aleksander Morgado <aleksander@...ksander.es> writes:

> These are the Foxconn-branded variants of the Dell DW5821e modules,
> same USB layout as those.
>
> The QMI interface is exposed in USB configuration #1:
>
> P:  Vendor=0489 ProdID=e0b4 Rev=03.18
> S:  Manufacturer=FII
> S:  Product=T77W968 LTE
> S:  SerialNumber=0123456789ABCDEF
> C:  #Ifs= 6 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:  If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I:  If#=0x1 Alt= 0 #EPs= 1 Cls=03(HID  ) Sub=00 Prot=00 Driver=usbhid
> I:  If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#=0x3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#=0x5 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
>
> Signed-off-by: Aleksander Morgado <aleksander@...ksander.es>
> ---
>  drivers/net/usb/qmi_wwan.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 56d334b9ad45..4196c0e32740 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1371,6 +1371,8 @@ static const struct usb_device_id products[] = {
>  	{QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)},	/* Quectel EG91 */
>  	{QMI_FIXED_INTF(0x2c7c, 0x0296, 4)},	/* Quectel BG96 */
>  	{QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)},	/* Fibocom NL678 series */
> +	{QMI_FIXED_INTF(0x0489, 0xe0b4, 0)},	/* Foxconn T77W968 LTE */
> +	{QMI_FIXED_INTF(0x0489, 0xe0b5, 0)},	/* Foxconn T77W968 LTE with eSIM support*/
>  
>  	/* 4. Gobi 1000 devices */
>  	{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},	/* Acer Gobi Modem Device */

Acked-by: Bjørn Mork <bjorn@...k.no>

Just one question, which I should have asked about the DW5821e too: Is
it possible to configure the firmware of these modems to USB2 only, and
do they work with the qmi_wwan driver then?

I suspect that these modems really need the SET_DTR quirk...  Or rather
that I should get around to making that default, as it seems most new
stuff needs it and most old stuff doesn't care.


Bjørn