netdev - Re: [PATCH net-next] nfc: pn533: pn533_phy_ops dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191113.121514.218723445139450529.davem@davemloft.net>
Date:   Wed, 13 Nov 2019 12:15:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     poeschel@...onage.de
Cc:     gustavo@...eddedor.com, kstewart@...uxfoundation.org,
        opensource@...ayne.com, tglx@...utronix.de, swinslow@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        keescook+coverity-bot@...omium.org
Subject: Re: [PATCH net-next] nfc: pn533: pn533_phy_ops dev_[up,down]
 return int

From: Lars Poeschel <poeschel@...onage.de>
Date: Wed, 13 Nov 2019 14:50:22 +0100

> Change dev_up and dev_down functions of struct pn533_phy_ops to return
> int. This way the pn533 core can report errors in the phy layer to upper
> layers.
> The only user of this is currently uart.c and it is changed to report
> the error of a possibly failing call to serdev_device_open.
> 
> Reported-by: coverity-bot <keescook+coverity-bot@...omium.org>
> Addresses-Coverity-ID: 1487395 ("Error handling issues")
> Fixes: c656aa4c27b1 ("nfc: pn533: add UART phy driver")
> Signed-off-by: Lars Poeschel <poeschel@...onage.de>

Applied, thanks Lars.