lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20191113.122307.27797700143710756.davem@davemloft.net>
Date:   Wed, 13 Nov 2019 12:23:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     cforno12@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, tlfalcon@...ux.ibm.com
Subject: Re: [PATCH net-next] ibmveth: Detect unsupported packets before
 sending to the hypervisor

From: Cris Forno <cforno12@...ux.vnet.ibm.com>
Date: Wed, 13 Nov 2019 09:44:07 -0600

> @@ -1011,6 +1011,29 @@ static int ibmveth_send(struct ibmveth_adapter *adapter,
>  	return 0;
>  }
>  
> +static int ibmveth_is_packet_unsupported(struct sk_buff *skb,
> +					 struct net_device *netdev)
> +{
> +	int ret = 0;
> +	struct ethhdr *ether_header;

Please use reverse christmas tree ordering for these local variables.

Thanks.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ