netdev - Re: [PATCH] net: atlantic: Signedness bug in aq_vec_isr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191113.143339.63552073098179182.davem@davemloft.net>
Date:   Wed, 13 Nov 2019 14:33:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     irusskikh@...vell.com, ndanilov@...vell.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: atlantic: Signedness bug in aq_vec_isr_legacy()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 13 Nov 2019 21:31:58 +0300

> irqreturn_t type is an enum and in this context it's unsigned, so "err"
> can't be irqreturn_t or it breaks the error handling.  In fact the "err"
> variable is only used to store integers (never irqreturn_t) so it should
> be declared as int.
> 
> I removed the initialization because it's not required.  Using a bogus
> initializer turns off GCC's uninitialized variable warnings.  Secondly,
> there is a GCC warning about unused assignments and we would like to
> enable that feature eventually so we have been trying to remove these
> unnecessary initializers.
> 
> Fixes: 7b0c342f1f67 ("net: atlantic: code style cleanup")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.