netdev - RE: [PATCH] tipc: add back tipc prefix to log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Nov 2019 23:42:47 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     Matt Bennett <matt.bennett@...iedtelesis.co.nz>,
        "ying.xue@...driver.com" <ying.xue@...driver.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] tipc: add back tipc prefix to log messages

Acked-by: Jon Maloy <jon.maloy@...csson.com>

> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On Behalf Of Matt Bennett
> Sent: 13-Nov-19 18:20
> To: Jon Maloy <jon.maloy@...csson.com>; ying.xue@...driver.com; davem@...emloft.net;
> netdev@...r.kernel.org; tipc-discussion@...ts.sourceforge.net
> Cc: linux-kernel@...r.kernel.org; Matt Bennett <matt.bennett@...iedtelesis.co.nz>
> Subject: [PATCH] tipc: add back tipc prefix to log messages
> 
> The tipc prefix for log messages generated by tipc was
> removed in commit 07f6c4bc048a ("tipc: convert tipc reference
> table to use generic rhashtable").
> 
> This is still a useful prefix so add it back.
> 
> Signed-off-by: Matt Bennett <matt.bennett@...iedtelesis.co.nz>
> ---
>  net/tipc/core.c | 2 --
>  net/tipc/core.h | 6 ++++++
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/net/tipc/core.c b/net/tipc/core.c
> index 23cb379a93d6..8f35060a24e1 100644
> --- a/net/tipc/core.c
> +++ b/net/tipc/core.c
> @@ -34,8 +34,6 @@
>   * POSSIBILITY OF SUCH DAMAGE.
>   */
> 
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -
>  #include "core.h"
>  #include "name_table.h"
>  #include "subscr.h"
> diff --git a/net/tipc/core.h b/net/tipc/core.h
> index 60d829581068..3042f654e0af 100644
> --- a/net/tipc/core.h
> +++ b/net/tipc/core.h
> @@ -60,6 +60,12 @@
>  #include <linux/rhashtable.h>
>  #include <net/genetlink.h>
> 
> +#ifdef pr_fmt
> +#undef pr_fmt
> +#endif
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  struct tipc_node;
>  struct tipc_bearer;
>  struct tipc_bc_base;
> --
> 2.24.0