netdev - Re: [PATCH net-next 12/12] net: dsa: vitesse: add tagger for Ocelot/Felix switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113021436.GB16688@lunn.ch>
Date:   Wed, 13 Nov 2019 03:14:36 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     jakub.kicinski@...ronome.com, davem@...emloft.net,
        alexandre.belloni@...tlin.com, f.fainelli@...il.com,
        vivien.didelot@...il.com, joergen.andreasen@...rochip.com,
        allan.nielsen@...rochip.com, horatiu.vultur@...rochip.com,
        claudiu.manoil@....com, netdev@...r.kernel.org,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 12/12] net: dsa: vitesse: add tagger for
 Ocelot/Felix switches

> --- a/drivers/net/dsa/vitesse/felix.c
> +++ b/drivers/net/dsa/vitesse/felix.c
> @@ -12,7 +12,7 @@
>  static enum dsa_tag_protocol felix_get_tag_protocol(struct dsa_switch *ds,
>  						    int port)
>  {
> -	return DSA_TAG_PROTO_NONE;
> +	return DSA_TAG_PROTO_OCELOT;
>  }

I would swap the order of these and the previous patch so you can
avoid this.

> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -67,6 +67,13 @@ config NET_DSA_TAG_EDSA
>  	  Say Y or M if you want to enable support for tagging frames for the
>  	  Marvell switches which use EtherType DSA headers.
>  
> +config NET_DSA_TAG_OCELOT
> +	tristate "Tag driver for Vitesse Ocelot/Felix switch"
> +	select PACKING
> +	help
> +	  Say Y or M if you want to enable support for tagging frames with the
> +	  Vitesse Ocelot (VSC7514) and Felix (VSC9959) switching cores.
> +
>  config NET_DSA_TAG_MTK
>  	tristate "Tag driver for Mediatek switches"
>  	help

This file is sorted so that the tristate strings appear in alphabetic
order when you do make menuconfig. This mean this entry to too early, and
NXP SJA1105 so too late. :-(

    Andrew