netdev - Re: [PATCH net-next 3/4] netfilter: nf_tables: Fix check the err for FLOW_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191114232704.475ucjd6hsk4mpqd@salvia>
Date:   Fri, 15 Nov 2019 00:27:04 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     wenxu@...oud.cn
Cc:     davem@...emloft.net, netfilter-devel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/4] netfilter: nf_tables: Fix check the err for
 FLOW_BLOCK_BIND setup call

This one is incomplete, right? I'm attaching an alternative patch.

On Wed, Nov 13, 2019 at 12:46:41PM +0800, wenxu@...oud.cn wrote:
> From: wenxu <wenxu@...oud.cn>
> 
> Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")
> Signed-off-by: wenxu <wenxu@...oud.cn>
> ---
>  net/netfilter/nf_tables_api.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
> index 2dc636f..0a00812 100644
> --- a/net/netfilter/nf_tables_api.c
> +++ b/net/netfilter/nf_tables_api.c
> @@ -5995,8 +5995,12 @@ static int nft_register_flowtable_net_hooks(struct net *net,
>  			}
>  		}
>  
> -		flowtable->data.type->setup(&flowtable->data, hook->ops.dev,
> -					    FLOW_BLOCK_BIND);
> +		err = flowtable->data.type->setup(&flowtable->data,
> +						  hook->ops.dev,
> +						  FLOW_BLOCK_BIND);
> +		if (err < 0)
> +			goto err_unregister_net_hooks;
> +
>  		err = nf_register_net_hook(net, &hook->ops);
>  		if (err < 0)
>  			goto err_unregister_net_hooks;
> -- 
> 1.8.3.1
> 

View attachment "0001-netfilter-nf_tables-unbind-callbacks-if-flowtable-ho.patch" of type "text/x-diff" (1200 bytes)