netdev - Re: [PATCH] net: macb: add missed tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d370a0a-95af-59f8-4ebf-7775cd44d8a0@microchip.com>
Date:   Fri, 15 Nov 2019 08:31:25 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <hslester96@...il.com>
CC:     <Nicolas.Ferre@...rochip.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: macb: add missed tasklet_kill



On 15.11.2019 04:32, Chuhong Yuan wrote:
> This driver forgets to kill tasklet in remove.
> Add the call to fix it.
> 
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

I think that you need to rebase it on latest net-next. Other than this:

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

> ---
>  drivers/net/ethernet/cadence/macb_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 1e1b774e1953..2ec416098fa3 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -4383,6 +4383,7 @@ static int macb_remove(struct platform_device *pdev)
> 
>         if (dev) {
>                 bp = netdev_priv(dev);
> +               tasklet_kill(&bp->hresp_err_tasklet);
>                 if (dev->phydev)
>                         phy_disconnect(dev->phydev);
>                 mdiobus_unregister(bp->mii_bus);
> --
> 2.24.0
> 
>