netdev - RE: [PATCH 1/3] can: flexcan: fix deadlock when using self wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB7PR04MB4618824F3A331AF9EC207C55E6700@DB7PR04MB4618.eurprd04.prod.outlook.com>
Date:   Fri, 15 Nov 2019 09:06:01 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Sean Nyekjaer <sean@...nix.com>,
        "mkl@...gutronix.de" <mkl@...gutronix.de>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH 1/3] can: flexcan: fix deadlock when using self wakeup


> -----Original Message-----
> From: Sean Nyekjaer <sean@...nix.com>
> Sent: 2019年11月15日 16:54
> To: Joakim Zhang <qiangqing.zhang@....com>; mkl@...gutronix.de;
> linux-can@...r.kernel.org
> Cc: dl-linux-imx <linux-imx@....com>; netdev@...r.kernel.org
> Subject: Re: [PATCH 1/3] can: flexcan: fix deadlock when using self wakeup
> 
> 
> 
> On 15/11/2019 06.09, Joakim Zhang wrote:
> >
> > Hi Sean,
> >
> > I remember that you are the first one sending out the patch to fix this issue,
> and I NACK the patch before.
> > I am so sorry for that, it can work fine after testing at my side.
> > Could you help double check at your side for this patch? Both wakeup from
> totally suspend and wakeup from suspending?
> >
> > With this patch, we can fix two problems:
> > 1) fix deadlock when using self wakeup
> > 2) frames out-of-order in first IRQ handler run after wakeup
> >
> > Thanks a lot!
> >
> > Best Regards,
> > Joakim Zhang
> 
> Hi Joakim,
> 
> 
> 
> We are mostly listening for broadcast packages, so we haven't noticed frames
> out-of-order :-)

Okay, I have discussed with Marc before, this could be possible. You can test with two boards, one receive and another transmit.
> 
> 
> I have checked this series, it comes out of suspend every time :-)

I am not quite understand, could you explain more, this patch cannot fix deadlock issue?

Best Regards,
Joakim Zhang
> /Sean