netdev - RE: [PATCH net 02/13] net: reject PTP periodic output requests with unsupported flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB5896990A94@ORSMSX121.amr.corp.intel.com>
Date:   Fri, 15 Nov 2019 01:14:15 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "Hall, Christopher S" <christopher.s.hall@...el.com>,
        Eugenia Emantayev <eugenia@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "sergei.shtylyov@...entembedded.com" 
        <sergei.shtylyov@...entembedded.com>,
        Feras Daoud <ferasda@...lanox.com>,
        "stefan.sorensen@...ctralink.com" <stefan.sorensen@...ctralink.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>,
        "brandon.streiff@...com" <brandon.streiff@...com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>
Subject: RE: [PATCH net 02/13] net: reject PTP periodic output requests with
 unsupported flags

> -----Original Message-----
> From: Saeed Mahameed <saeedm@...lanox.com>
> Sent: Thursday, November 14, 2019 3:58 PM
> To: richardcochran@...il.com; netdev@...r.kernel.org
> Cc: Hall, Christopher S <christopher.s.hall@...el.com>; Eugenia Emantayev
> <eugenia@...lanox.com>; davem@...emloft.net;
> sergei.shtylyov@...entembedded.com; Feras Daoud <ferasda@...lanox.com>;
> stefan.sorensen@...ctralink.com; Brown, Aaron F <aaron.f.brown@...el.com>;
> brandon.streiff@...com; Keller, Jacob E <jacob.e.keller@...el.com>; Kirsher,
> Jeffrey T <jeffrey.t.kirsher@...el.com>; intel-wired-lan@...ts.osuosl.org;
> felipe.balbi@...ux.intel.com
> Subject: Re: [PATCH net 02/13] net: reject PTP periodic output requests with
> unsupported flags
> 
> On Thu, 2019-11-14 at 10:44 -0800, Richard Cochran wrote:
> > From: Jacob Keller <jacob.e.keller@...el.com>
> >
> LGTM, just there might be a problem with old tools that didn't clear
> the flags upon request and expected PTP periodic .. they will stop to
> work with new kernel, am i am not sure if such tools do exist.
> 

Not quite. This is why there is a V2 ioctl now. The V1 ioctl now explicitly disables any bits set beyond the originally defined ones, so that callers of v1 will continue to work, even if they send junk data.

Thus, old tools should continue working with the old interface, while tools that want new functionality must be upgraded to use the v2 ioctls.

Thanks,
Jake

> But the fact now that we have PTP_PEROUT_ONE_SHOT, we need to trust
> both driver and tools to do the right thing.
> 
> What are the tools to test PTP_PEROUT_ONE_SHOT ? to support this in
> mlx5 it is just a matter of a flipping a bit.
> 
> Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>
>