netdev - Re: [PATCH net-next v3 2/2] cxgb4: add TC-MATCHALL classifier ingress offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191115135318.GB2158@nanopsycho>
Date:   Fri, 15 Nov 2019 14:53:18 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nirranjan@...lsio.com,
        vishal@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net-next v3 2/2] cxgb4: add TC-MATCHALL classifier
 ingress offload

Fri, Nov 15, 2019 at 01:14:21PM CET, rahul.lakkireddy@...lsio.com wrote:

[...]


>@@ -26,9 +37,13 @@ struct cxgb4_tc_matchall {
> };
> 
> int cxgb4_tc_matchall_replace(struct net_device *dev,
>-			      struct tc_cls_matchall_offload *cls_matchall);
>+			      struct tc_cls_matchall_offload *cls_matchall,
>+			      bool ingress);
> int cxgb4_tc_matchall_destroy(struct net_device *dev,
>-			      struct tc_cls_matchall_offload *cls_matchall);
>+			      struct tc_cls_matchall_offload *cls_matchall,
>+			      bool ingress);
>+int cxgb4_tc_matchall_stats(struct net_device *dev,
>+			    struct tc_cls_matchall_offload *cls_matchall);

Hmm, you only add stats function in this second patch. Does that mean
you don't care for stats in egress?
>From looking at cxgb_setup_tc_matchall() looks like I'm right.
Why?

> 
> int cxgb4_init_tc_matchall(struct adapter *adap);
> void cxgb4_cleanup_tc_matchall(struct adapter *adap);
>-- 
>2.24.0
>