netdev - Re: [PATCH iproute2-next] ip link: Add support to get SR-IOV VF node GUID and port GUID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191115152442.GE6763@unreal>
Date:   Fri, 15 Nov 2019 17:24:42 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Danit Goldberg <danitg@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next] ip link: Add support to get SR-IOV VF node
 GUID and port GUID

On Thu, Nov 14, 2019 at 01:35:11PM -0700, David Ahern wrote:
> On 11/14/19 6:31 AM, Leon Romanovsky wrote:
> > diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> > index b72eb7a1..ed72d0bd 100644
> > --- a/ip/ipaddress.c
> > +++ b/ip/ipaddress.c
> > @@ -484,6 +484,29 @@ static void print_vfinfo(FILE *fp, struct ifinfomsg *ifi, struct rtattr *vfinfo)
> >  				   vf_spoofchk->setting);
> >  	}
> >
> > +#define GUID_STR_LEN 24
> > +	if (vf[IFLA_VF_IB_NODE_GUID]) {
> > +		char buf[GUID_STR_LEN];
>
> buf should be declared with SPRINT_BUF; see other users of ll_addr_n2a.
> And, print_vfinfo already has b1 declared so you do not need a new one;
> just change buf to b1.

Thanks, I posted v1.
https://lore.kernel.org/linux-rdma/20191115152155.246821-1-leon@kernel.org