netdev - Re: [PATCH] net: phylink: update to use phy_support_asym

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191115200703.GS25745@shell.armlinux.org.uk>
Date:   Fri, 15 Nov 2019 20:07:03 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phylink: update to use phy_support_asym_pause()

Forgetting the net-next tag again...

On Fri, Nov 15, 2019 at 08:05:45PM +0000, Russell King wrote:
> Use phy_support_asym_pause() rather than open-coding it.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/phylink.c | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 2b70b4d50573..a68d664b65a3 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -697,11 +697,6 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy)
>  	__ETHTOOL_DECLARE_LINK_MODE_MASK(supported);
>  	int ret;
>  
> -	memset(&config, 0, sizeof(config));
> -	linkmode_copy(supported, phy->supported);
> -	linkmode_copy(config.advertising, phy->advertising);
> -	config.interface = pl->link_config.interface;
> -
>  	/*
>  	 * This is the new way of dealing with flow control for PHYs,
>  	 * as described by Timur Tabi in commit 529ed1275263 ("net: phy:
> @@ -709,10 +704,12 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy)
>  	 * using our validate call to the MAC, we rely upon the MAC
>  	 * clearing the bits from both supported and advertising fields.
>  	 */
> -	if (phylink_test(supported, Pause))
> -		phylink_set(config.advertising, Pause);
> -	if (phylink_test(supported, Asym_Pause))
> -		phylink_set(config.advertising, Asym_Pause);
> +	phy_support_asym_pause(phy);
> +
> +	memset(&config, 0, sizeof(config));
> +	linkmode_copy(supported, phy->supported);
> +	linkmode_copy(config.advertising, phy->advertising);
> +	config.interface = pl->link_config.interface;
>  
>  	ret = phylink_validate(pl, supported, &config);
>  	if (ret)
> -- 
> 2.20.1
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up