netdev - Re: [PATCH net-next] mlxsw: spectrum_router: Allocate discard adjacency entry when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Nov 2019 12:25:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net-next] mlxsw: spectrum_router: Allocate discard
 adjacency entry when needed

From: Ido Schimmel <idosch@...sch.org>
Date: Thu, 14 Nov 2019 11:54:19 +0200

> From: Ido Schimmel <idosch@...lanox.com>
> 
> Commit 0c3cbbf96def ("mlxsw: Add specific trap for packets routed via
> invalid nexthops") allocated an adjacency entry during driver
> initialization whose purpose is to discard packets hitting the route
> pointing to it.
> 
> These adjacency entries are allocated from a resource called KVD linear
> (KVDL). There are situations in which the user can decide to set the
> size of this resource (via devlink-resource) to 0, in which case the
> driver will not be able to load.
> 
> Therefore, instead of pre-allocating this adjacency entry, simply
> allocate it only when needed. A variable indicating the validity of the
> entry is added and is used to ensure it is only allocated and written
> once and that it is freed after all the routes were flushed.
> 
> Fixes: 0c3cbbf96def ("mlxsw: Add specific trap for packets routed via invalid nexthops")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>

Applied.