netdev - Re: [PATCH net-next] net: openvswitch: don't call pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191115.124344.295228162013300379.davem@davemloft.net>
Date:   Fri, 15 Nov 2019 12:43:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     pshelar@....org, gvrose8192@...il.com, netdev@...r.kernel.org,
        dev@...nvswitch.org, joe@....org, u9012063@...il.com
Subject: Re: [PATCH net-next] net: openvswitch: don't call pad_packet if
 not necessary

From: xiangxia.m.yue@...il.com
Date: Thu, 14 Nov 2019 23:51:08 +0800

> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> The nla_put_u16/nla_put_u32 makes sure that
> *attrlen is align. The call tree is that:
> 
> nla_put_u16/nla_put_u32
>   -> nla_put		attrlen = sizeof(u16) or sizeof(u32)
>   -> __nla_put		attrlen
>   -> __nla_reserve	attrlen
>   -> skb_put(skb, nla_total_size(attrlen))
> 
> nla_total_size returns the total length of attribute
> including padding.
> 
> Cc: Joe Stringer <joe@....org>
> Cc: William Tu <u9012063@...il.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>

Applied, thanks.