netdev - Re: [PATCH bpf] selftests: bpf: xdping is not meant to be run standalone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <427e0b06-679e-5621-f828-be545e6ca3b1@iogearbox.net>
Date:   Fri, 15 Nov 2019 23:06:13 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jiri Benc <jbenc@...hat.com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     Alan Maguire <alan.maguire@...cle.com>
Subject: Re: [PATCH bpf] selftests: bpf: xdping is not meant to be run
 standalone

On 11/15/19 1:42 PM, Jiri Benc wrote:
> The actual test to run is test_xdping.sh, which is already in TEST_PROGS.
> The xdping program alone is not runnable with 'make run_tests', it
> immediatelly fails due to missing arguments.
> 
> Move xdping to TEST_GEN_PROGS_EXTENDED in order to be built but not run.
> 
> Fixes: cd5385029f1d ("selftests/bpf: measure RTT from xdp using xdping")
> Cc: Alan Maguire <alan.maguire@...cle.com>
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

Any objections if I take this to bpf-next as otherwise this will create an ugly
merge conflict between bpf and bpf-next given selftests have been heavily reworked
in there.

Thanks,
Daniel