netdev - Re: [PATCH 0/5] bnx2x: Remove function casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191116.125116.355989617007258357.davem@davemloft.net>
Date:   Sat, 16 Nov 2019 12:51:16 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     aelior@...vell.com, skalluru@...vell.com,
        GR-everest-linux-l2@...vell.com, samitolvanen@...gle.com,
        netdev@...r.kernel.org, kernel-hardening@...ts.openwall.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] bnx2x: Remove function casts

From: Kees Cook <keescook@...omium.org>
Date: Thu, 14 Nov 2019 21:07:10 -0800

> In order to make the entire kernel usable under Clang's Control Flow
> Integrity protections, function prototype casts need to be avoided
> because this will trip CFI checks at runtime (i.e. a mismatch between
> the caller's expected function prototype and the destination function's
> prototype). Many of these cases can be found with -Wcast-function-type,
> which found that bnx2x had a bunch of needless (or at least confusing)
> function casts. This series removes them all.

Looks reasonable, series applied to net-next.

Thank you.