lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 16 Nov 2019 18:56:46 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Edward Cree <ecree@...arflare.com>
Subject: Re: [PATCH net-next 2/2] ipv4: use dst hint for ipv4 list receive

Hi Paolo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc7 next-20191115]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-introduce-and-use-route-hint/20191116-172108
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 20021578ba226bda1f0ddf50e4d4a12ea1c6c6c1
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from ./arch/powerpc/include/generated/asm/local64.h:1:0,
                    from include/linux/u64_stats_sync.h:72,
                    from include/net/snmp.h:47,
                    from include/net/netns/mib.h:5,
                    from include/net/net_namespace.h:17,
                    from include/linux/inet.h:42,
                    from net/ipv4/ip_input.c:122:
   include/linux/u64_stats_sync.h: In function 'u64_stats_read':
   include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    #define local64_read(l)  local_read(&(l)->a)
                                        ^
   include/linux/u64_stats_sync.h:80:9: note: in expansion of macro 'local64_read'
     return local64_read(&p->v);
            ^~~~~~~~~~~~
   In file included from include/asm-generic/local64.h:22:0,
                    from ./arch/powerpc/include/generated/asm/local64.h:1,
                    from include/linux/u64_stats_sync.h:72,
                    from include/net/snmp.h:47,
                    from include/net/netns/mib.h:5,
                    from include/net/net_namespace.h:17,
                    from include/linux/inet.h:42,
                    from net/ipv4/ip_input.c:122:
   arch/powerpc/include/asm/local.h:20:24: note: expected 'local_t * {aka struct <anonymous> *}' but argument is of type 'const local_t * {aka const struct <anonymous> *}'
    static __inline__ long local_read(local_t *l)
                           ^~~~~~~~~~
   net/ipv4/ip_input.c: In function 'ip_list_rcv_finish':
>> net/ipv4/ip_input.c:570:19: error: 'struct netns_ipv4' has no member named 'fib_has_custom_rules'; did you mean 'fib_has_custom_local_routes'?
       if (!net->ipv4.fib_has_custom_rules &&
                      ^~~~~~~~~~~~~~~~~~~~
                      fib_has_custom_local_routes

vim +570 net/ipv4/ip_input.c

   542	
   543	static void ip_list_rcv_finish(struct net *net, struct sock *sk,
   544				       struct list_head *head)
   545	{
   546		struct ip_route_input_hint _hint, *hint = NULL;
   547		struct dst_entry *curr_dst = NULL;
   548		struct sk_buff *skb, *next;
   549		struct list_head sublist;
   550	
   551		INIT_LIST_HEAD(&sublist);
   552		list_for_each_entry_safe(skb, next, head, list) {
   553			struct net_device *dev = skb->dev;
   554			struct dst_entry *dst;
   555	
   556			skb_list_del_init(skb);
   557			/* if ingress device is enslaved to an L3 master device pass the
   558			 * skb to its handler for processing
   559			 */
   560			skb = l3mdev_ip_rcv(skb);
   561			if (!skb)
   562				continue;
   563			if (ip_rcv_finish_core(net, sk, skb, dev, hint) == NET_RX_DROP)
   564				continue;
   565	
   566			dst = skb_dst(skb);
   567			if (curr_dst != dst) {
   568				struct rtable *rt = (struct rtable *)dst;
   569	
 > 570				if (!net->ipv4.fib_has_custom_rules &&
   571				    rt->rt_type != RTN_BROADCAST) {
   572					_hint.refdst = skb->_skb_refdst;
   573					_hint.daddr = ip_hdr(skb)->daddr;
   574					_hint.tos = ip_hdr(skb)->tos;
   575					_hint.local = rt->rt_type == RTN_LOCAL;
   576					hint = &_hint;
   577				} else {
   578					hint = NULL;
   579				}
   580	
   581				/* dispatch old sublist */
   582				if (!list_empty(&sublist))
   583					ip_sublist_rcv_finish(&sublist);
   584				/* start new sublist */
   585				INIT_LIST_HEAD(&sublist);
   586				curr_dst = dst;
   587			}
   588			list_add_tail(&skb->list, &sublist);
   589		}
   590		/* dispatch final sublist */
   591		ip_sublist_rcv_finish(&sublist);
   592	}
   593	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25413 bytes)

Powered by blists - more mailing lists