lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Nov 2019 08:06:29 +0000 From: merez@...eaurora.org To: Colin King <colin.king@...onical.com> Cc: Kalle Valo <kvalo@...eaurora.org>, "David S . Miller" <davem@...emloft.net>, linux-wireless@...r.kernel.org, wil6210@....qualcomm.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] wil6210: fix break that is never reached because of zero'ing of a retry counter On 2019-11-15 14:09, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > There is a check on the retry counter invalid_buf_id_retry that is > always > false because invalid_buf_id_retry is initialized to zero on each > iteration > of a while-loop. Fix this by initializing the retry counter before the > while-loop starts. > > Addresses-Coverity: ("Logically dead code") > Fixes: b4a967b7d0f5 ("wil6210: reset buff id in status message after > completion") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > > Note: not tested, so I'm not sure if the loop retry threshold is high > enough > > --- Reviewed-by: Maya Erez <merez@...eaurora.org>
Powered by blists - more mailing lists