netdev - Re: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 17 Nov 2019 14:46:50 +0000
From:   Tariq Toukan <tariqt@...lanox.com>
To:     David Miller <davem@...emloft.net>,
        "lrizzo@...gle.com" <lrizzo@...gle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [PATCH] net/mlx4_en: fix mlx4 ethtool -N insertion



On 11/16/2019 11:10 PM, David Miller wrote:
> From: Luigi Rizzo <lrizzo@...gle.com>
> Date: Fri, 15 Nov 2019 12:12:25 -0800
> 
>> ethtool expects ETHTOOL_GRXCLSRLALL to set ethtool_rxnfc->data with the
>> total number of entries in the rx classifier table.  Surprisingly, mlx4
>> is missing this part (in principle ethtool could still move forward and
>> try the insert).
>>
>> Tested: compiled and run command:
>> 	phh13:~# ethtool -N eth1 flow-type udp4  queue 4
>> 	Added rule with ID 255
>>
>> Signed-off-by: Luigi Rizzo <lrizzo@...gle.com>
>> Change-Id: I18a72f08dfcfb6b9f6aa80fbc12d58553e1fda76
> 
> Luigi, _always_ CC: the appropriate maintainer when making changes to the
> kernel, as per the top-level MAINTAINERS file.
> 
> Tariq et al., please review.
> 

Reviewed-by: Tariq Toukan <tariqt@...lanox.com>

Thanks for your patch.

Tariq