netdev - Re: [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Nov 2019 14:02:36 +0100
From:   Matteo Croce <mcroce@...hat.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net/ipv4: fix sysctl max for fib_multipath_hash_policy

On Mon, Nov 18, 2019 at 1:46 PM Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
>
> Commit eec4844fae7c ("proc/sysctl: add shared variables for range
> check") did:
> -               .extra2         = &two,
> +               .extra2         = SYSCTL_ONE,
> here, which doesn't seem to be intentional, given the changelog.
> This patch restores it to the previous, as the value of 2 still makes
> sense (used in fib_multipath_hash()).
>

Nice catch.
Somehow a chunk in 363887a2cdfeb was partially reverted.

Acked-by: Matteo Croce <mcroce@...hat.com>

-- 
Matteo Croce
per aspera ad upstream