netdev - Re: [PATCH 02/15] octeontx2-af: Add support for importing firmware data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191118132811.091d086c@cakuba.netronome.com>
Date:   Mon, 18 Nov 2019 13:28:11 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Linu Cherian <lcherian@...vell.com>,
        Rakesh Babu <rsaladi2@...vell.com>,
        Vamsi Attunuru <vamsi.attunuru@...vell.com>,
        Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH 02/15] octeontx2-af: Add support for importing firmware
 data

On Sun, 17 Nov 2019 21:44:13 +0530, sunil.kovvuri@...il.com wrote:
> From: Linu Cherian <lcherian@...vell.com>
> 
> Firmware data is essentially a block of one time configuration data
> exported from firmware to kernel through shared memory. Base address
> of this memory is obtained through CGX firmware interface commands.
> 
> With this in place, MAC address of CGX mapped functions are inited
> from firmware data if available else they are inited with
> random MAC address.
> 
> Also
> - Added a new mbox for PF/VF to retrieve it's MAC address.
> - Now RVU MSIX vector address is also retrieved from this fwdata struct
>   instead of from CSR. Otherwise when kexec/kdump crash kernel loads
>   CSR will have a IOVA setup by primary kernel which impacts
>   RVU PF/VF's interrupts.
> 
> Signed-off-by: Linu Cherian <lcherian@...vell.com>
> Signed-off-by: Rakesh Babu <rsaladi2@...vell.com>
> Signed-off-by: Vamsi Attunuru <vamsi.attunuru@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>

Again, confusing about what this code is actually doing. Looks like
it's responding to some mailbox requests..

Please run checkpatch --strict and fix all the whitespace issues, incl.
missing spaces around comments and extra new lines.