netdev - Re: [PATCH v3 net-next 1/2] UDP tunnel encapsulation module for tunnelling different protocols like MPLS,IP,NSH etc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 19:10:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        davem@...emloft.net, corbet@....net, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, scott.drennan@...ia.com, jbenc@...hat.com,
        martin.varghese@...ia.com
Subject: Re: [PATCH v3 net-next 1/2] UDP tunnel encapsulation module for
 tunnelling different protocols like MPLS,IP,NSH etc.

Hi Martin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc8 next-20191120]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Martin-Varghese/Bare-UDP-L3-Encapsulation-Module/20191116-135036
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 20021578ba226bda1f0ddf50e4d4a12ea1c6c6c1
config: powerpc-tqm8560_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/net/dst_metadata.h:6:0,
                    from net/core/dev.c:101:
   include/net/ip_tunnels.h: In function 'iptunnel_get_v4_rt':
>> include/net/ip_tunnels.h:514:39: error: 'const struct ip_tunnel_info' has no member named 'dst_cache'
     dst_cache = (struct dst_cache *)&info->dst_cache;
                                          ^~
--
   In file included from net/ipv4/ip_tunnel_core.c:26:0:
   include/net/ip_tunnels.h: In function 'iptunnel_get_v4_rt':
>> include/net/ip_tunnels.h:514:39: error: 'const struct ip_tunnel_info' has no member named 'dst_cache'
     dst_cache = (struct dst_cache *)&info->dst_cache;
                                          ^~
   In file included from net/ipv4/ip_tunnel_core.c:27:0:
   include/net/ip6_tunnel.h: In function 'ip6tunnel_get_dst':
>> include/net/ip6_tunnel.h:191:39: error: 'const struct ip_tunnel_info' has no member named 'dst_cache'
     dst_cache = (struct dst_cache *)&info->dst_cache;
                                          ^~
>> include/net/ip6_tunnel.h:193:9: error: implicit declaration of function 'dst_cache_get_ip6'; did you mean 'dst_cache_get_ip4'? [-Werror=implicit-function-declaration]
      dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
            ^~~~~~~~~~~~~~~~~
            dst_cache_get_ip4
   include/net/ip6_tunnel.h:193:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
          ^
>> include/net/ip6_tunnel.h:209:3: error: implicit declaration of function 'dst_cache_set_ip6'; did you mean 'dst_cache_set_ip4'? [-Werror=implicit-function-declaration]
      dst_cache_set_ip6(dst_cache, dst, &fl6->saddr);
      ^~~~~~~~~~~~~~~~~
      dst_cache_set_ip4
   cc1: some warnings being treated as errors

vim +514 include/net/ip_tunnels.h

   492	
   493	static inline  struct rtable *iptunnel_get_v4_rt(struct sk_buff *skb,
   494			struct net_device *dev,
   495			struct net *net,
   496			struct flowi4 *fl4,
   497			const struct ip_tunnel_info *info,
   498			bool  use_cache)
   499	{
   500		struct dst_cache *dst_cache;
   501		struct rtable *rt = NULL;
   502		__u8 tos;
   503	
   504	
   505		memset(fl4, 0, sizeof(*fl4));
   506		fl4->flowi4_mark = skb->mark;
   507		fl4->flowi4_proto = IPPROTO_UDP;
   508		fl4->daddr = info->key.u.ipv4.dst;
   509		fl4->saddr = info->key.u.ipv4.src;
   510	
   511		tos = info->key.tos;
   512		fl4->flowi4_tos = RT_TOS(tos);
   513	
 > 514		dst_cache = (struct dst_cache *)&info->dst_cache;
   515		if (use_cache) {
   516			rt = dst_cache_get_ip4(dst_cache, &fl4->saddr);
   517			if (rt)
   518				return rt;
   519		}
   520		rt = ip_route_output_key(net, fl4);
   521		if (IS_ERR(rt)) {
   522			netdev_dbg(dev, "no route to %pI4\n", &fl4->daddr);
   523			return ERR_PTR(-ENETUNREACH);
   524		}
   525		if (rt->dst.dev == dev) { /* is this necessary? */
   526			netdev_dbg(dev, "circular route to %pI4\n", &fl4->daddr);
   527			ip_rt_put(rt);
   528			return ERR_PTR(-ELOOP);
   529		}
   530		if (use_cache)
   531			dst_cache_set_ip4(dst_cache, &rt->dst, fl4->saddr);
   532		return rt;
   533	}
   534	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (16148 bytes)