netdev - Re: [PATCH net] ipv6/route: return if there is no fib_nh_gw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 08:04:45 -0700
From:   David Ahern <dsahern@...il.com>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] ipv6/route: return if there is no fib_nh_gw_family

On 11/20/19 12:39 AM, Hangbin Liu wrote:
> Previously we will return directly if (!rt || !rt->fib6_nh.fib_nh_gw_family)
> in function rt6_probe(), but after commit cc3a86c802f0
> ("ipv6: Change rt6_probe to take a fib6_nh"), the logic changed to
> return if there is fib_nh_gw_family.
> 
> Fixes: cc3a86c802f0 ("ipv6: Change rt6_probe to take a fib6_nh")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  net/ipv6/route.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index e60bf8e7dd1a..3f83ea851ebf 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -634,7 +634,7 @@ static void rt6_probe(struct fib6_nh *fib6_nh)
>  	 * Router Reachability Probe MUST be rate-limited
>  	 * to no more than one per minute.
>  	 */
> -	if (fib6_nh->fib_nh_gw_family)
> +	if (!fib6_nh->fib_nh_gw_family)
>  		return;
>  
>  	nh_gw = &fib6_nh->fib_nh_gw6;
> 

good catch. Thanks for the patch.

Reviewed-by: David Ahern <dsahern@...il.com>