netdev - Re: [PATCH v5 net-next 0/3] add DMA-sync-for-device capability to page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191120180512.GB26040@apalos.home>
Date:   Wed, 20 Nov 2019 20:05:12 +0200
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org,
        davem@...emloft.net, lorenzo.bianconi@...hat.com,
        mcroce@...hat.com, jonathan.lemon@...il.com
Subject: Re: [PATCH v5 net-next 0/3] add DMA-sync-for-device capability to
 page_pool API

On Wed, Nov 20, 2019 at 05:45:22PM +0200, Lorenzo Bianconi wrote:
> > On Wed, 20 Nov 2019 16:54:16 +0200
> > Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> > 
> > > Do not change naming convention for the moment since the changes will
> > > hit other drivers as well. I will address it in another series.
> > 
> > Yes, I agree, as I also said over IRC (freenode #xdp).
> > 
> > The length (dma_sync_size) API addition to __page_pool_put_page() is
> > for now confined to this driver (mvneta).  We can postpone the API-name
> > discussion, as you have promised here (and on IRC) that you will
> > "address it in another series".  (Guess, given timing, the followup
> > series and discussion will happen after the merge window...)
> 
> Right, I will work on it after next merging window.

As we discussed we can go a step further as page_pool_put_page() and
page_pool_recycle_direct() can probably go away. Syncing with the len make more
sense as long. As we document the 'allow_direct' flag sufficiently we can just
rename __page_pool_put_page -> page_pool_put_page and keep one function only. 

In any case this patchset is fine for this merge window

for the series

Acked-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>