netdev - Re: [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191120144632.0658d920@cakuba.netronome.com>
Date:   Wed, 20 Nov 2019 14:46:32 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: sfp: add some quirks for GPON modules

On Wed, 20 Nov 2019 11:42:47 +0000, Russell King wrote:
>  static const struct sfp_quirk sfp_quirks[] = {
> +	{
> +		// Alcatel Lucent G-010S-P can operate at 2500base-X, but
> +		// incorrectly report 2500MBd NRZ in their EEPROM
> +		.vendor = "ALCATELLUCENT",
> +		.part = "G010SP",
> +		.modes = sfp_quirk_2500basex,
> +	}, {
> +		// Alcatel Lucent G-010S-A can operate at 2500base-X, but
> +		// report 3.2GBd NRZ in their EEPROM
> +		.vendor = "ALCATELLUCENT",
> +		.part = "3FE46541AA",
> +		.modes = sfp_quirk_2500basex,
> +	}, {
> +		// Huawei MA5671A can operate at 2500base-X, but report 1.2GBd
> +		// NRZ in their EEPROM
> +		.vendor = "HUAWEI",
> +		.part = "MA5671A",
> +		.modes = sfp_quirk_2500basex,
> +	},
>  };

nit: no C++ comment style?