netdev - Re: [PATCH iproute2-next] rdma: Rewrite custom JSON and prints logic to use common API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afe19f2b-a2dc-f1ad-9186-0505d7ea61ca@gmail.com>
Date:   Tue, 19 Nov 2019 19:33:13 -0700
From:   David Ahern <dsahern@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Ido Kalir <idok@...lanox.com>, netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: Re: [PATCH iproute2-next] rdma: Rewrite custom JSON and prints logic
 to use common API

On 11/18/19 1:35 AM, Leon Romanovsky wrote:
> From: Ido Kalir <idok@...lanox.com>
> 
> Instead of doing open-coded solution to generate JSON and prints, let's
> reuse existing infrastructure and APIs to do the same as ip/*.
> 
> Before this change:
>  if (rd->json_output)
>      jsonw_uint_field(rd->jw, "sm_lid", sm_lid);
>  else
>      pr_out("sm_lid %u ", sm_lid);
> 
> After this change:
>  print_uint(PRINT_ANY, "sm_lid", "sm_lid %u ", sm_lid);
> 
> All the print functions are converted to support color but for now the
> type of color is COLOR_NONE. This is done as a preparation to addition
> of color enable option. Such change will require rewrite of command line
> arguments parser which is out-of-scope for this patch.
> 
> Signed-off-by: Ido Kalir <idok@...lanox.com>
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>

Applied to iproute2-next. Thank you for doing this!

Now we just devlink to be converted.