netdev - RE: [next-queue/net-next PATCH] e1000e: Use netdev_info instead of pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B97179772@ORSMSX103.amr.corp.intel.com>
Date:   Wed, 20 Nov 2019 02:55:20 +0000
From:   "Brown, Aaron F" <aaron.f.brown@...el.com>
To:     Alexander Duyck <alexander.duyck@...il.com>,
        "joe@...ches.com" <joe@...ches.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "zdai@...ux.vnet.ibm.com" <zdai@...ux.vnet.ibm.com>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "smorumu1@...ibm.com" <smorumu1@...ibm.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [next-queue/net-next PATCH] e1000e: Use netdev_info instead of
 pr_info for link messages

> From: Alexander Duyck <alexander.duyck@...il.com>
> Sent: Thursday, October 31, 2019 9:59 AM
> To: joe@...ches.com; Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>;
> davem@...emloft.net
> Cc: zdai@...ux.vnet.ibm.com; nhorman@...hat.com;
> netdev@...r.kernel.org; smorumu1@...ibm.com; intel-wired-
> lan@...ts.osuosl.org; Brown, Aaron F <aaron.f.brown@...el.com>;
> sassmann@...hat.com
> Subject: [next-queue/net-next PATCH] e1000e: Use netdev_info instead of
> pr_info for link messages
> 
> From: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> 
> Replace the pr_info calls with netdev_info in all cases related to the
> netdevice link state.
> 
> As a result of this patch the link messages will change as shown below.
> Before:
> e1000e: ens3 NIC Link is Down
> e1000e: ens3 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx
> 
> After:
> e1000e 0000:00:03.0 ens3: NIC Link is Down
> e1000e 0000:00:03.0 ens3: NIC Link is Up 1000 Mbps Full Duplex, Flow Control:
> Rx/Tx
> 
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> ---
> 
> Since Joe hasn't gotten back to me on if he wanted to do the patch or if
> he wanted me to do it I just went ahead and did it. This should address the
> concerns he had about the message formatting in "e1000e: Use rtnl_lock to
> prevent race".
> 
>  drivers/net/ethernet/intel/e1000e/netdev.c |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

Tested-by: Aaron Brown <aaron.f.brown@...el.com>