netdev - Re: [PATCH net] net: phylink: fix link mode modification in PHY mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191119.185615.1082982024930046589.davem@davemloft.net>
Date:   Tue, 19 Nov 2019 18:56:15 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phylink: fix link mode modification in PHY
 mode

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Tue, 19 Nov 2019 17:28:14 +0000

> Modifying the link settings via phylink_ethtool_ksettings_set() and
> phylink_ethtool_set_pauseparam() didn't always work as intended for
> PHY based setups, as calling phylink_mac_config() would result in the
> unresolved configuration being committed to the MAC, rather than the
> configuration with the speed and duplex setting.
> 
> This would work fine if the update caused the link to renegotiate,
> but if no settings have changed, phylib won't trigger a renegotiation
> cycle, and the MAC will be left incorrectly configured.
> 
> Avoid calling phylink_mac_config() unless we are using an inband mode
> in phylink_ethtool_ksettings_set(), and use phy_set_asym_pause() as
> introduced in 4.20 to set the PHY settings in
> phylink_ethtool_set_pauseparam().
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Applied.