netdev - Re: [PATCH V2 net] net: hns3: fix a wrong reset interrupt status mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191119.191102.582170155760201896.davem@davemloft.net>
Date:   Tue, 19 Nov 2019 19:11:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tanhuazhong@...wei.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        linuxarm@...wei.com, jakub.kicinski@...ronome.com
Subject: Re: [PATCH V2 net] net: hns3: fix a wrong reset interrupt status
 mask

From: Huazhong Tan <tanhuazhong@...wei.com>
Date: Wed, 20 Nov 2019 10:07:15 +0800

> According to hardware user manual, bits5~7 in register
> HCLGE_MISC_VECTOR_INT_STS means reset interrupts status,
> but HCLGE_RESET_INT_M is defined as bits0~2 now. So it
> will make hclge_reset_err_handle() read the wrong reset
> interrupt status.
> 
> This patch fixes this wrong bit mask.
> 
> Fixes: 2336f19d7892 ("net: hns3: check reset interrupt status when reset fails")
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> ---
> Change log:
> V1->V2: fixes comment from David Miller.

Applied.