netdev - Re: [PATCH -next v2] rtl8xxxu: Remove set but not used variable 'vif', 'dev', 'len'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Nov 2019 07:48:32 +0000
From:   Kalle Valo <kvalo@...eaurora.org>
To:     zhengbin <zhengbin13@...wei.com>
Cc:     <Jes.Sorensen@...il.com>, <davem@...emloft.net>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <zhengbin13@...wei.com>
Subject: Re: [PATCH -next v2] rtl8xxxu: Remove set but not used variable 'vif', 'dev',
 'len'

zhengbin <zhengbin13@...wei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5396:24: warning: variable vif set but not used [-Wunused-but-set-variable]
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5397:17: warning: variable dev set but not used [-Wunused-but-set-variable]
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function rtl8xxxu_c2hcmd_callback:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:5400:6: warning: variable len set but not used [-Wunused-but-set-variable]
> 
> They are introduced by commit e542e66b7c2e ("rtl8xxxu:
> add bluetooth co-existence support for single antenna"), but never used,
> so remove them.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: zhengbin <zhengbin13@...wei.com>
> Reviewed-by: Chris Chiu <chiu@...lessm.com>

Patch applied to wireless-drivers-next.git, thanks.

eac08515d7bd rtl8xxxu: Remove set but not used variable 'vif','dev','len'

-- 
https://patchwork.kernel.org/patch/11250639/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches