netdev - Re: [PATCH net-next] octeontx2-af: Fix uninitialized variable in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+sq2Cf=u509E-er_N8rzgkP4XdetNpogNqn+AVv-9AzmoQKrg@mail.gmail.com>
Date:   Thu, 21 Nov 2019 15:11:13 +0530
From:   Sunil Kovvuri <sunil.kovvuri@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Sunil Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Jerin Jacob <jerinj@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] octeontx2-af: Fix uninitialized variable in debugfs

On Thu, Nov 21, 2019 at 2:53 PM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> If rvu_get_blkaddr() fails, then this rvu_cgx_nix_cuml_stats() returns
> zero and we write some uninitialized data into the debugfs output.
>
> On the error paths, the use of the uninitialized "*stat" is harmless,
> but it will lead to a Smatch warning (static analysis) and a UBSan
> warning (runtime analysis) so we should prevent that as well.
>

Thanks for the fix.

Thanks,
Sunil.